Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread Martin Gräßlin
On Jan. 7, 2014, 3:14 p.m., Martin Gräßlin wrote: checking obviously makes sense, though it shouldn't be needed. There must be something else which is wrong here, too. Could you try what the value of WId is in these cases? I wouldn't be surprised if it were 0. Oh and that code

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread David Edmundson
On Jan. 7, 2014, 2:14 p.m., Martin Gräßlin wrote: checking obviously makes sense, though it shouldn't be needed. There must be something else which is wrong here, too. Could you try what the value of WId is in these cases? I wouldn't be surprised if it were 0. Oh and that code

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114895/ --- (Updated Jan. 8, 2014, 12:18 p.m.) Status -- This change has been

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114895/#review47047 --- This review has been submitted with commit

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread Martin Gräßlin
On Jan. 7, 2014, 3:14 p.m., Martin Gräßlin wrote: checking obviously makes sense, though it shouldn't be needed. There must be something else which is wrong here, too. Could you try what the value of WId is in these cases? I wouldn't be surprised if it were 0. Oh and that code

Review Request 114895: Guard against null QX11Info::connection()

2014-01-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114895/ --- Review request for KDE Frameworks, Martin Gräßlin and Marco Martin.

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-07 Thread David Edmundson
On Jan. 7, 2014, 2:14 p.m., Martin Gräßlin wrote: checking obviously makes sense, though it shouldn't be needed. There must be something else which is wrong here, too. Could you try what the value of WId is in these cases? I wouldn't be surprised if it were 0. Oh and that code

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-07 Thread Martin Gräßlin
On Jan. 7, 2014, 3:14 p.m., Martin Gräßlin wrote: checking obviously makes sense, though it shouldn't be needed. There must be something else which is wrong here, too. Could you try what the value of WId is in these cases? I wouldn't be surprised if it were 0. Oh and that code