Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

2014-01-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/#review47909 --- This review has been submitted with commit

Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/ --- (Updated Jan. 19, 2014, 1:21 p.m.) Review request for Build System,

Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS

2014-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/#review47736 --- Looks good to me. (i.e. wait a bit in case of objections,