Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114921/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114921/#review47123 --- Ship it! I say ship it - deleting anything that has been

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114921/#review47124 --- Ship it! Yep, as discussed. Looks good, except for one

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114921/#review47125 --- Why not simply make the QMenu* the parent of the QAction? I

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114921/ --- (Updated Jan. 9, 2014, 9:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114921/#review47128 --- This review has been submitted with commit

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

2014-01-09 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114921/ --- (Updated Jan. 9, 2014, 9:28 p.m.) Status -- This change has been