Review Request 115049: Do not require ktranscript to be installed for the test to run

2014-01-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/ --- Review request for KDE Frameworks and Chusslove Illich. Bugs: 329994

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

2014-01-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/#review47490 --- autotests/ktranscripttest.cpp

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

2014-01-16 Thread Aurélien Gâteau
On Jan. 16, 2014, 12:11 p.m., Aleix Pol Gonzalez wrote: autotests/ktranscripttest.cpp, line 52 https://git.reviewboard.kde.org/r/115049/diff/1/?file=234121#file234121line52 This limits the cwd. Maybe you can pass it as a preprocess definition? aka with

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

2014-01-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/#review47498 --- Ship it! Ship It! - Alex Merry On Jan. 16, 2014, 12:58

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

2014-01-16 Thread Alex Merry
On Jan. 16, 2014, 1:20 p.m., Alex Merry wrote: Ship It! Aurélien: you put the wrong REVIEW: line in. You'll have to close this manually. - Alex --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

2014-01-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115049/ --- (Updated Jan. 16, 2014, 6:02 p.m.) Status -- This change has been

Re: Review Request 115049: Do not require ktranscript to be installed for the test to run

2014-01-16 Thread Aurélien Gâteau
On Jan. 16, 2014, 2:20 p.m., Alex Merry wrote: Ship It! Alex Merry wrote: Aurélien: you put the wrong REVIEW: line in. You'll have to close this manually. Ohoh, the fail :( - Aurélien --- This is an automatically