Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-20 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47785 --- src/kmessagewidget.h

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-20 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 20, 2014, 4:12 p.m.) Review request for KDE Frameworks,

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-20 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47816 --- Ship it! Ship It! - Aurélien Gâteau On Jan. 20, 2014,

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47817 --- This review has been submitted with commit

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-19 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 19, 2014, 10:56 a.m.) Review request for KDE Frameworks,

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47746 --- autotests/kmessagewidgetautotest.cpp

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47749 --- autotests/kmessagewidgetautotest.cpp

Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- Review request for KDE Frameworks, Albert Astals Cid and Aurélien Gâteau.

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 18, 2014, 5:47 p.m.) Review request for KDE Frameworks,

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/ --- (Updated Jan. 18, 2014, 6:13 p.m.) Review request for KDE Frameworks,

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115101/#review47655 --- Hm, how does KMessageWidget behave, if you post the next

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Dominik Haumann
On Jan. 18, 2014, 7:46 p.m., Christoph Feck wrote: Hm, how does KMessageWidget behave, if you post the next message without waiting for the animation to finish? I somehow feel that the queuing should be done inside KMessageWidget. KMessageWidget has no post function at all. It is just