Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-02-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48745 --- This is the only framework that installs a config-foo.h file,

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-01-27 Thread Alex Merry
On Jan. 27, 2014, 7:36 a.m., Kevin Ottens wrote: Why not... makes me want to ask the same for the other HAVE_FOO we have in the other frameworks. You might have opened the pandora box. :-) Martin Gräßlin wrote: yes the same reasoning applies to all frameworks. Though one could also

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48377 --- This review has been submitted with commit

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-01-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/ --- (Updated Jan. 27, 2014, 12:30 p.m.) Status -- This change has been

Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-01-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-01-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48326 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Jan.

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115148/#review48343 --- Ship it! Why not... makes me want to ask the same for the