Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-22 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 22, 2014, 6:20 p.m.) Status -- This change has been

Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- Review request for KDE Frameworks. Repository: kconfigwidgets

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- Jut to be sure, are the two changes (optional KDocTools and

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Alexander Richardson
On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? two separate commits, however kdoctools is broken on windows so I made it optional to allow building - Alexander

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Luigi Toscano
On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? Alexander Richardson wrote: two separate commits, however kdoctools is broken on windows so I made it optional to allow building

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47947 --- CMakeLists.txt

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Luigi Toscano
On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? Alexander Richardson wrote: two separate commits, however kdoctools is broken on windows so I made it optional to allow building

Re: Review Request 115202: Allow building KConfigWidgets on Windows

2014-01-21 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 22, 2014, 1:06 a.m.) Review request for KDE Frameworks.