Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review47996 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014,

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 --- Ship it! This seems sensible to me; however, I do wonder if

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Well, we

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Alex Merry
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Aleix Pol Gonzalez
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Alex Merry
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 2:54 p.m.) Status -- This change has been

Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48036 --- This review has been submitted with commit

Review Request 115211: Mark target created by ecm_add_test as non GUI by default

2014-01-21 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.