Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review47996 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 22, 2014, 1:28 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 1:28 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 --- Ship it! This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). - Alex Merry On Jan. 22, 2014, 1:28 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 1:28 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Well, we can't change the default, can we? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 --- On Jan. 22, 2014, 1:28 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 1:28 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix Pol Gonzalez wrote: Well, we can't change the default, can we? I don't understand what you mean. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 --- On Jan. 22, 2014, 1:28 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 1:28 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix Pol Gonzalez wrote: Well, we can't change the default, can we? Alex Merry wrote: I don't understand what you mean. If we have a /mark as non gui/ function is because executables are /gui executables/ by default. Having an ecm_mark_gui_executable() would make this weird I'd say. (TBH, it seems to me cmake shouldn't know about that at all, but I take it as just a limitation on Windows (and Android)) - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 --- On Jan. 22, 2014, 1:28 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 1:28 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
On Jan. 22, 2014, 12:08 p.m., Alex Merry wrote: This seems sensible to me; however, I do wonder if ECM should also provide an ecm_mark_gui_executable function as well (I'm thinking of the case where most of the tests should be non-gui, but a handful want to display widgets). Aleix Pol Gonzalez wrote: Well, we can't change the default, can we? Alex Merry wrote: I don't understand what you mean. Aleix Pol Gonzalez wrote: If we have a /mark as non gui/ function is because executables are /gui executables/ by default. Having an ecm_mark_gui_executable() would make this weird I'd say. (TBH, it seems to me cmake shouldn't know about that at all, but I take it as just a limitation on Windows (and Android)) We have it because we call set(CMAKE_WIN32_EXECUTABLE ON) in KDECMakeSettings.cmake. CMake documentation is unforthcoming about the default in the absence of that setting, but I think it is off. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48009 --- On Jan. 22, 2014, 1:28 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 1:28 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 2:54 p.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115211: Mark target created by ecm_add_test as non GUI by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/#review48036 --- This review has been submitted with commit 7cf3afc38e03d52d76848a6f0aa6d880d5ba97fd by Alex Richardson to branch master. - Commit Hook On Jan. 22, 2014, 1:28 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- (Updated Jan. 22, 2014, 1:28 a.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115211: Mark target created by ecm_add_test as non GUI by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115211/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Mark target created by ecm_add_test as non GUI by default This behaviour can be overriden by passing the GUI flag to the command Diffs - modules/ECMAddTests.cmake ff97d764d58c781d6c37dd08c8cb175ce500962e Diff: https://git.reviewboard.kde.org/r/115211/diff/ Testing --- Oketeta unit tests wouldn't build on windows before this commit, now they do Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
