Re: Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Feb. 3, 2014, 6:24 p.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48848
---
This review has been submitted with commit
63705e373e06cb524b57e44d415d85ca12e95778 by Alex Richardson to branch master.
- Commit Hook
On Jan. 27, 2014, 11:40 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 27, 2014, 11:40 p.m.)
Review request for KDE Frameworks and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48849
---
This review has been submitted with commit
a533bcd4185026964e01ae1938dfaf4825d490f9 by Alex Richardson to branch master.
- Commit Hook
On Jan. 27, 2014, 11:40 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 27, 2014, 11:40 p.m.)
Review request for KDE Frameworks and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Feb. 3, 2014, 6:24 p.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48461
---
Ship it!
Hmm, it now appears that PIC was already broken. But your patch at least makes
it broken in the same way as before... *adds to TODO list*
- Alex Merry
On Jan. 27, 2014, 11:40 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 27, 2014, 11:40 p.m.)
Review request for KDE Frameworks and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
Review request for KDE Frameworks, kdewin and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48421
---
src/imageformats/pic_write.cpp
https://git.reviewboard.kde.org/r/115345/#comment34247
Missing qint16 ?
(Question mark, because I am unsure, I did not look at either of the
functions)
- Christoph Feck
On Jan. 27, 2014, 9:38 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 27, 2014, 9:38 p.m.)
Review request for KDE Frameworks, kdewin and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48422
---
Just ran a quick test, using the imageconverter tool in the tests/ directory.
I created orig.pcx and orig.pic before applying the patch, with
./imageconverter /some/image.bmp orig.pcx
./imageconverter /some/image.bmp orig.pic
and then did the same after patching with patched.pcx and patched.pic. Then
cmp orig.pcx patched.pcx
is fine, but
cmp orig.pic patched.pic
orig.pic patched.pic differ: byte 93, line 1
So something has gone wrong :-)
- Alex Merry
On Jan. 27, 2014, 9:38 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 27, 2014, 9:38 p.m.)
Review request for KDE Frameworks, kdewin and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
On Jan. 27, 2014, 10:36 p.m., Alex Merry wrote:
Just ran a quick test, using the imageconverter tool in the tests/
directory. I created orig.pcx and orig.pic before applying the patch, with
./imageconverter /some/image.bmp orig.pcx
./imageconverter /some/image.bmp orig.pic
and then did the same after patching with patched.pcx and patched.pic. Then
cmp orig.pcx patched.pcx
is fine, but
cmp orig.pic patched.pic
orig.pic patched.pic differ: byte 93, line 1
So something has gone wrong :-)
Incidentally, somewhere down my TODO list is autotests for kimageformats. I
was thinking lossy formats would be an issue, but this sort of test should work
fine (I don't think any image formats actually introduce randomness).
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48422
---
On Jan. 27, 2014, 9:38 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 27, 2014, 9:38 p.m.)
Review request for KDE Frameworks, kdewin and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 28, 2014, 12:40 a.m.)
Review request for KDE Frameworks and Alex Merry.
Changes
---
fix qint32 - qint16 issue
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs (updated)
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115345: Fix kimageformats build with MSVC
On Jan. 27, 2014, 11:36 p.m., Alex Merry wrote:
Just ran a quick test, using the imageconverter tool in the tests/
directory. I created orig.pcx and orig.pic before applying the patch, with
./imageconverter /some/image.bmp orig.pcx
./imageconverter /some/image.bmp orig.pic
and then did the same after patching with patched.pcx and patched.pic. Then
cmp orig.pcx patched.pcx
is fine, but
cmp orig.pic patched.pic
orig.pic patched.pic differ: byte 93, line 1
So something has gone wrong :-)
Alex Merry wrote:
Incidentally, somewhere down my TODO list is autotests for kimageformats.
I was thinking lossy formats would be an issue, but this sort of test should
work fine (I don't think any image formats actually introduce randomness).
Issue should be fixed now. Can't test whether it works because currently I only
have access to my Windows machine and it won't build before this patch.
I will check whether it works tomorrow evening
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48422
---
On Jan. 28, 2014, 12:40 a.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 28, 2014, 12:40 a.m.)
Review request for KDE Frameworks and Alex Merry.
Repository: kimageformats
Description
---
1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32
Diffs
-
src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388
src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294
src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71
Diff: https://git.reviewboard.kde.org/r/115345/diff/
Testing
---
didn't compile before, does now
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
