Re: Review Request 115347: Remove Qt5Xml dependency

2014-01-28 Thread Kevin Funk

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115347/
---

(Updated Jan. 28, 2014, 8:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Remove Qt5Xml dependency

Not needed, no?


Diffs
-

  CMakeLists.txt 94afe9f5f414a437e519242026ebaf2a838ffc88 

Diff: https://git.reviewboard.kde.org/r/115347/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115347: Remove Qt5Xml dependency

2014-01-27 Thread Kevin Funk

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115347/
---

Review request for KDE Frameworks.


Repository: kcompletion


Description
---

Remove Qt5Xml dependency

Not needed, no?


Diffs
-

  CMakeLists.txt 94afe9f5f414a437e519242026ebaf2a838ffc88 

Diff: https://git.reviewboard.kde.org/r/115347/diff/


Testing
---


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115347: Remove Qt5Xml dependency

2014-01-27 Thread Alexander Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115347/#review48448
---

Ship it!


grep -irn xml * gives me nothing, looks unused

- Alexander Richardson


On Jan. 28, 2014, 2:48 a.m., Kevin Funk wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115347/
 ---
 
 (Updated Jan. 28, 2014, 2:48 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kcompletion
 
 
 Description
 ---
 
 Remove Qt5Xml dependency
 
 Not needed, no?
 
 
 Diffs
 -
 
   CMakeLists.txt 94afe9f5f414a437e519242026ebaf2a838ffc88 
 
 Diff: https://git.reviewboard.kde.org/r/115347/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Kevin Funk
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel