Re: Review Request 115360: Remove the allocator and visibility check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/#review48514 --- Ship it! Ship It! - David Faure On Jan. 28, 2014, 10:43 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 10:43 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove the allocator and visibility check I am reasonably sure the allocator check is out of date, given our minimum GCC version, and it was not used for anything interesting anyway. The visibility check will not be performed in practice, as this file will almost always be included before any check for Qt. Diffs - kde-modules/KDECompilerSettings.cmake ba9b03f1c86061dd740960220b6411bbce541617 Diff: https://git.reviewboard.kde.org/r/115360/diff/ Testing --- Everything kdesrc-build knows about builds (GCC 4.8.2 20131219; Linux with glibc 2.18). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115360: Remove the allocator and visibility check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/#review48531 --- This review has been submitted with commit 4e867a836bafd113c6d4b34c17eeb564089308a2 by Alex Merry to branch master. - Commit Hook On Jan. 28, 2014, 10:43 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 10:43 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove the allocator and visibility check I am reasonably sure the allocator check is out of date, given our minimum GCC version, and it was not used for anything interesting anyway. The visibility check will not be performed in practice, as this file will almost always be included before any check for Qt. Diffs - kde-modules/KDECompilerSettings.cmake ba9b03f1c86061dd740960220b6411bbce541617 Diff: https://git.reviewboard.kde.org/r/115360/diff/ Testing --- Everything kdesrc-build knows about builds (GCC 4.8.2 20131219; Linux with glibc 2.18). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115360: Remove the allocator and visibility check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 4:41 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove the allocator and visibility check I am reasonably sure the allocator check is out of date, given our minimum GCC version, and it was not used for anything interesting anyway. The visibility check will not be performed in practice, as this file will almost always be included before any check for Qt. Diffs - kde-modules/KDECompilerSettings.cmake 3419cb1266c63f9cdec0501ae340aabe7c0b6096 Diff: https://git.reviewboard.kde.org/r/115360/diff/ Testing (updated) --- KCoreAddons still configures and compiles (GCC 4.8.2 20131219; Linux with glibc 2.18). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115360: Remove the allocator and visibility check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 8:16 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Remove the allocator and visibility check I am reasonably sure the allocator check is out of date, given our minimum GCC version, and it was not used for anything interesting anyway. The visibility check will not be performed in practice, as this file will almost always be included before any check for Qt. Diffs - kde-modules/KDECompilerSettings.cmake 3419cb1266c63f9cdec0501ae340aabe7c0b6096 Diff: https://git.reviewboard.kde.org/r/115360/diff/ Testing (updated) --- Everything kdesrc-build knows about builds (GCC 4.8.2 20131219; Linux with glibc 2.18). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115360: Remove the allocator and visibility check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115360/ --- (Updated Jan. 28, 2014, 10:43 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Changes --- Remove a stray set() call. Repository: extra-cmake-modules Description --- Remove the allocator and visibility check I am reasonably sure the allocator check is out of date, given our minimum GCC version, and it was not used for anything interesting anyway. The visibility check will not be performed in practice, as this file will almost always be included before any check for Qt. Diffs (updated) - kde-modules/KDECompilerSettings.cmake ba9b03f1c86061dd740960220b6411bbce541617 Diff: https://git.reviewboard.kde.org/r/115360/diff/ Testing --- Everything kdesrc-build knows about builds (GCC 4.8.2 20131219; Linux with glibc 2.18). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
