Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-16 Thread Kevin Ottens
Hello, On Saturday 15 February 2014 23:27:40 David Faure wrote: Looks like a historical thing to me, from before kstyle got integrated into frameworkintegration. If I read git log correctly, this src/kstyle/CMakeLists.txt file comes from Kévin's commit 3864cfe2347af01b. Kévin, any reason

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-07 Thread David Faure
On Saturday 01 February 2014 13:27:49 Alex Merry wrote: - KStyle can once again be built standalone Is there any reason for this? I ask because I noticed that this was another place where the KF5 version had to be updated at release time, the only one that is not in

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-07 Thread Alex Merry
On 07/02/14 08:58, David Faure wrote: On Saturday 01 February 2014 13:27:49 Alex Merry wrote: - KStyle can once again be built standalone Is there any reason for this? I ask because I noticed that this was another place where the KF5 version had to be updated at release time, the only

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/#review48815 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 1, 2014,

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/ --- (Updated Feb. 3, 2014, 12:26 p.m.) Status -- This change has been

Re: Review Request 115421: Clean up the CMakeLists.txt files

2014-02-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/#review48817 --- This review has been submitted with commit

Review Request 115421: Clean up the CMakeLists.txt files

2014-02-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115421/ --- Review request for KDE Frameworks. Repository: frameworkintegration