Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/#review49608 --- Well, clearly the use of a pointer was because of the either

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/ --- (Updated Feb. 12, 2014, 8:24 a.m.) Review request for KDE Frameworks and

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/#review49625 --- Ship it! Ship It! - David Faure On Feb. 12, 2014, 7:24

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/ --- (Updated Feb. 12, 2014, 7:32 a.m.) Status -- This change has been

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/#review49629 --- This review has been submitted with commit

Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/ --- Review request for KDE Frameworks and Jekyll Wu. Repository: kde-runtime

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/#review49455 --- drkonqi/main.cpp

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-10 Thread Aleix Pol Gonzalez
On Feb. 10, 2014, 4:14 p.m., Aleix Pol Gonzalez wrote: drkonqi/main.cpp, line 74 https://git.reviewboard.kde.org/r/115629/diff/1/?file=243089#file243089line74 You can instantiate QApplication in the stack, instead of calling new+delete. Also you probably want to