Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

2014-02-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/#review50388 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 20, 2014,

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

2014-02-20 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/ --- (Updated Feb. 20, 2014, 5:15 p.m.) Status -- This change has been

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

2014-02-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/#review50389 --- This review has been submitted with commit

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

2014-02-17 Thread Alexander Richardson
On Feb. 17, 2014, 7:39 a.m., Matthew John Dawson wrote: autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp, line 26 https://git.reviewboard.kde.org/r/115634/diff/1/?file=243130#file243130line26 Is this a copy + paste error? Yes, leftover from old version of this unittest

Re: Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

2014-02-17 Thread Matthew John Dawson
On Feb. 17, 2014, 1:39 a.m., Matthew John Dawson wrote: autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp, line 153 https://git.reviewboard.kde.org/r/115634/diff/1/?file=243130#file243130line153 As this appears to preform the same check as the function below, I rather

Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

2014-02-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/ --- Review request for KDE Frameworks. Repository: kconfig Description