Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 26, 2014, 4:53 p.m.) Status -- This change has been

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50447 --- Way to big to properly review to be honest. That said, I

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-19 Thread Aleix Pol Gonzalez
On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote: src/knotificationmanager.cpp, line 180 https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180 ? Martin Klapetek wrote: Yet once again the description xD - it's full of ... FIXMEs to indicate

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-19 Thread Martin Klapetek
On Feb. 19, 2014, 11:06 a.m., Aleix Pol Gonzalez wrote: src/knotificationmanager.cpp, line 180 https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180 ? Martin Klapetek wrote: Yet once again the description xD - it's full of ... FIXMEs to indicate

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-19 Thread Nicolás Alvarez
On Feb. 19, 2014, 7:06 a.m., Aleix Pol Gonzalez wrote: src/notifybypopupgrowl.h, line 37 https://git.reviewboard.kde.org/r/115695/diff/3/?file=243849#file243849line37 Is growl still the thing for MacOS X? Martin Klapetek wrote: I'm not sure to be honest...I've heard they

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50136 --- Ping, any comments? - Martin Klapetek On Feb. 13, 2014,

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 13, 2014, 11:14 a.m.) Review request for kde-workspace,

Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- Review request for kde-workspace, KDE Frameworks, Plasma, and Sune

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review49650 --- src/notifybypopup.cpp

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 12, 2014, 4:54 p.m.) Review request for kde-workspace, KDE