Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/ --- (Updated Feb. 15, 2014, 12:21 p.m.) Status -- This change has been

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/#review49816 --- This review has been submitted with commit

Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/ --- Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/#review49709 --- Ship it! That seems like a reasonable compromise to me. I

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115723/#review49747 --- src/core/kprotocolmanager.cpp

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Martin Gräßlin
On Feb. 13, 2014, 11:27 p.m., Alexander Richardson wrote: src/core/kprotocolmanager.cpp, line 690 https://git.reviewboard.kde.org/r/115723/diff/1/?file=243874#file243874line690 Maybe move the Q_OS_MAC up as the first check, then there is no need for !defined(Q_OS_DARWIN) I