Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review52049 --- This review has been submitted with commit

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-03-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review51961 --- Ship it! autotests/kconfigtest.cpp

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-03-04 Thread Alexander Richardson
On March 4, 2014, 10:11 p.m., David Faure wrote: autotests/kconfigtest.cpp, line 86 https://git.reviewboard.kde.org/r/115875/diff/2/?file=251983#file251983line86 Just curious, what's the reason for the .. then? Doesn't this still make this test potentially conflict with other

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review50580 --- autotests/kconfigtest.cpp

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-02-21 Thread Alexander Richardson
On Feb. 21, 2014, 7:35 a.m., Kevin Ottens wrote: autotests/kconfigtest.cpp, line 219 https://git.reviewboard.kde.org/r/115875/diff/1/?file=244867#file244867line219 Hm we're loosing the test mode for QStandardPaths, I don't think that's desirable. It is done inside

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review50435 --- autotests/kconfigtest.cpp

Review Request 115875: kconfigtest: write everything into a subdirectory

2014-02-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/ --- Review request for KDE Frameworks. Repository: kconfig Description