Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review51972 --- This review has been submitted with commit

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review51415 --- The implementation all looks fine. The only concern I have

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread David Faure
On March 1, 2014, 11:15 a.m., Alex Merry wrote: The implementation all looks fine. The only concern I have is that it's an odd location for it; I wouldn't expect to go looking for a method to invoke Help in KConfigWidgets. Although I'm not sure where it would go instead, given the

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review51426 --- Ship it! Ship It! - Alex Merry On Feb. 23, 2014, 11 a.m.,

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-03-01 Thread Alex Merry
On March 1, 2014, 11:15 a.m., Alex Merry wrote: The implementation all looks fine. The only concern I have is that it's an odd location for it; I wouldn't expect to go looking for a method to invoke Help in KConfigWidgets. Although I'm not sure where it would go instead, given the

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-27 Thread David Faure
On Feb. 24, 2014, 9:22 p.m., Albert Astals Cid wrote: src/khelpclient.cpp, line 35 https://git.reviewboard.kde.org/r/115959/diff/2/?file=245608#file245608line35 Just curious, who is doing this call setApplicationName() with the name of the desktop file thing? I know KApplication

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-27 Thread David Faure
On Feb. 24, 2014, 9:22 p.m., Albert Astals Cid wrote: src/khelpclient.cpp, line 76 https://git.reviewboard.kde.org/r/115959/diff/2/?file=245608#file245608line76 url is always help:/ isn't it? Not sure i understand the comment David Faure wrote: ? Not sure I understand *your*

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review50765 --- src/khelpclient.cpp

Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/ --- Review request for KDE Frameworks. Repository: kconfigwidgets

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/ --- (Updated Feb. 23, 2014, 9:56 a.m.) Review request for KDE Frameworks and

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review50567 --- src/khelpclient.h