Re: Review Request 116030: Extend tests to cover getConf... calls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/#review51435 --- I'm wondering why create the test config on the fly, and not simply add one to the autotests directory. There are already a number of test-specific input files in there. src/ktranscript.cpp https://git.reviewboard.kde.org/r/116030/#comment36215 Leftover debug line. - Chusslove Illich On Feb. 25, 2014, 5:17 p.m., Kevin Krammer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/ --- (Updated Feb. 25, 2014, 5:17 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Write a test config to a test location using QStandardPath's test feature. Test getConf... calls in success and fallback mode. Actually found a missing bool - script bool conversion. fixed Chusslove: how about using ktranscript.ini for the file to look up using QStandardPaths? Maybe a more obvious on other platforms? Diffs - autotests/CMakeLists.txt 6e926ba autotests/ktranscripttest.h 7ea7818 autotests/ktranscripttest.cpp e3a27ff autotests/test.js ad53b1b autotests/testhelpers.h PRE-CREATION autotests/testhelpers.cpp PRE-CREATION src/ktranscript.cpp 44c8b63 Diff: https://git.reviewboard.kde.org/r/116030/diff/ Testing --- All previously existing tests continue to run :) Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116030: Extend tests to cover getConf... calls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/#review51451 --- This review has been submitted with commit 92b0edbdb12a15b852483d977e49eab0c74421bd by Kevin Krammer to branch master. - Commit Hook On March 1, 2014, 4:24 p.m., Kevin Krammer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/ --- (Updated March 1, 2014, 4:24 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Write a test config to a test location using QStandardPath's test feature. Test getConf... calls in success and fallback mode. Actually found a missing bool - script bool conversion. fixed Chusslove: how about using ktranscript.ini for the file to look up using QStandardPaths? Maybe a more obvious on other platforms? Diffs - autotests/CMakeLists.txt 6e926ba autotests/ktranscript-test.ini PRE-CREATION autotests/ktranscripttest.h 7ea7818 autotests/ktranscripttest.cpp e3a27ff autotests/test.js ad53b1b autotests/testhelpers.h PRE-CREATION autotests/testhelpers.cpp PRE-CREATION src/ktranscript.cpp 44c8b63 Diff: https://git.reviewboard.kde.org/r/116030/diff/ Testing --- All previously existing tests continue to run :) Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116030: Extend tests to cover getConf... calls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/ --- (Updated March 1, 2014, 5:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Write a test config to a test location using QStandardPath's test feature. Test getConf... calls in success and fallback mode. Actually found a missing bool - script bool conversion. fixed Chusslove: how about using ktranscript.ini for the file to look up using QStandardPaths? Maybe a more obvious on other platforms? Diffs - autotests/CMakeLists.txt 6e926ba autotests/ktranscript-test.ini PRE-CREATION autotests/ktranscripttest.h 7ea7818 autotests/ktranscripttest.cpp e3a27ff autotests/test.js ad53b1b autotests/testhelpers.h PRE-CREATION autotests/testhelpers.cpp PRE-CREATION src/ktranscript.cpp 44c8b63 Diff: https://git.reviewboard.kde.org/r/116030/diff/ Testing --- All previously existing tests continue to run :) Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116030: Extend tests to cover getConf... calls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/ --- (Updated Feb. 25, 2014, 4:17 p.m.) Review request for KDE Frameworks and Chusslove Illich. Changes --- Added function to remove test config after test and call it from cleanupTestCase. Renamed new config file to ktranscript.ini, should fit better in cross-platform world Repository: ki18n Description --- Write a test config to a test location using QStandardPath's test feature. Test getConf... calls in success and fallback mode. Actually found a missing bool - script bool conversion. fixed Chusslove: how about using ktranscript.ini for the file to look up using QStandardPaths? Maybe a more obvious on other platforms? Diffs (updated) - autotests/CMakeLists.txt 6e926ba autotests/ktranscripttest.h 7ea7818 autotests/ktranscripttest.cpp e3a27ff autotests/test.js ad53b1b autotests/testhelpers.h PRE-CREATION autotests/testhelpers.cpp PRE-CREATION src/ktranscript.cpp 44c8b63 Diff: https://git.reviewboard.kde.org/r/116030/diff/ Testing --- All previously existing tests continue to run :) Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116030: Extend tests to cover getConf... calls
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Write a test config to a test location using QStandardPath's test feature. Test getConf... calls in success and fallback mode. Actually found a missing bool - script bool conversion. fixed Chusslove: how about using ktranscript.ini for the file to look up using QStandardPaths? Maybe a more obvious on other platforms? Diffs - autotests/CMakeLists.txt 6e926ba autotests/ktranscripttest.cpp e3a27ff autotests/test.js ad53b1b autotests/testhelpers.h PRE-CREATION autotests/testhelpers.cpp PRE-CREATION src/ktranscript.cpp 44c8b63 Diff: https://git.reviewboard.kde.org/r/116030/diff/ Testing --- All previously existing tests continue to run :) Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
