Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

2014-02-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116056/#review50915 --- Argh, sorry, I completely missed this review request, and

Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

2014-02-26 Thread Matthieu Gallien
On Feb. 26, 2014, 12:07 p.m., Alex Merry wrote: ioslave/CMakeLists.txt, line 9 https://git.reviewboard.kde.org/r/116056/diff/1/?file=246123#file246123line9 I found I needed to link against KF5::I18n; I wonder why you didn't? The problem is in KIO

Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

2014-02-26 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116056/ --- (Updated Feb. 26, 2014, 10:39 p.m.) Status -- This change has been

Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

2014-02-25 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116056/ --- (Updated Feb. 25, 2014, 9:02 p.m.) Review request for KDE Frameworks.