---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116462/#review51729
---
Ship it!
Makes sense to me.
- Aleix Pol Gonzalez
On Feb. 27, 2014, 9:59 p.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116462/
---
(Updated Feb. 27, 2014, 9:59 p.m.)
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Repository: frameworkintegration
Description
---
Keep KSharedConfigPtr(kdeglobals) around in KHintSettings.
This makes KFontSettingsData end up using the same instance, rather than
each of these two classes parsing kdeglobals on startup, in turn.
Had to fix the unittest again, it doesn't use QStandardPaths' testMode,
so it must ensure to set its special environment before the platformtheme
is created.
strace -e open kate | grep -v NOENT | grep kdeglobals | wc -l
went from 5 to 4.
Diffs
-
src/platformtheme/khintssettings.cpp
c4de4badc6187d841af36e29e083ffd2ca475d82
src/platformtheme/khintssettings.h 8f353837884590bc6a8409df7273435824273f49
src/platformtheme/kfontsettingsdata.cpp
62990ce45c1a175c3b57710c8a38268d08908733
autotests/kfontsettingsdata_unittest.cpp
4ee33fea72905128112226248667499489b1c692
Diff: https://git.reviewboard.kde.org/r/116462/diff/
Testing
---
as described: unittests in frameworkintegration + running kate.
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
