---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/
---
(Updated March 5, 2014, 9 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review52029
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review52067
---
Note that find_package(Wayland COMPONENTS Client Egl)
On March 5, 2014, 12:31 p.m., Alex Merry wrote:
Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What
shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl).
I hadn't realised that about pkg_check_modules(), though. I'll have to update
the docs I
On March 5, 2014, 1:31 p.m., Alex Merry wrote:
Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What
shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl).
Alex Merry wrote:
I hadn't realised that about pkg_check_modules(), though. I'll have
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/
---
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review51904
---
+1 but someone else has to approve
- Martin Gräßlin
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review51912
---
Ship it!
Looks good to me.
- Aleix Pol Gonzalez
On March