Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/ --- (Updated March 5, 2014, 9 a.m.) Status -- This change has been

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review52029 --- This review has been submitted with commit

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review52067 --- Note that find_package(Wayland COMPONENTS Client Egl)

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Alex Merry
On March 5, 2014, 12:31 p.m., Alex Merry wrote: Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl). I hadn't realised that about pkg_check_modules(), though. I'll have to update the docs I

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Aurélien Gâteau
On March 5, 2014, 1:31 p.m., Alex Merry wrote: Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl). Alex Merry wrote: I hadn't realised that about pkg_check_modules(), though. I'll have

Review Request 116598: Check versions for individual components of Wayland

2014-03-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review51904 --- +1 but someone else has to approve - Martin Gräßlin On

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review51912 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On March