---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review53374
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---
(Updated March 18, 2014, 10:25 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review53189
---
Ship it!
Ship It!
- Kevin Ottens
On March 14, 2014, 8:46
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52928
---
src/kcompletionbox.h
On March 14, 2014, 9:18 a.m., David Faure wrote:
src/kcompletionbox.h, line 229
https://git.reviewboard.kde.org/r/116747/diff/4/?file=253685#file253685line229
That two 'd's too many.
Aaargh!! I added those two d's for refactoring and then I forgot to change it
(actually I forgot
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---
(Updated March 14, 2014, 8:46 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52953
---
Ship it!
Ship It!
- Alex Merry
On March 14, 2014, 8:46
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52881
---
src/kcompletionbox.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---
(Updated March 13, 2014, 10:13 p.m.)
Review request for KDE Frameworks.
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52740
---
Looks sensible to me, but I'll let Aleix reply.
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
On March 11, 2014, 11:17 p.m., Aleix Pol Gonzalez wrote:
src/kcompletionbox.h, line 228
https://git.reviewboard.kde.org/r/116747/diff/1/?file=253404#file253404line228
I wouldn't leave the implementation here. Move it to the .cpp file,
this way it can be changed in the future, if
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---
(Updated March 12, 2014, 10:54 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---
(Updated March 12, 2014, 10:57 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116747/#review52703
---
src/kcompletionbox.h
19 matches
Mail list logo
