Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/#review53813 --- Ship it! Ship It! - David Faure On March 21, 2014, 3:47 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 23, 2014, 2:46 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/#review53816 --- This review has been submitted with commit 8d13c18a4e4d01bb3982e7f76578b4f62ba867c3 by Alex Merry to branch master. - Commit Hook On March 21, 2014, 3:47 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 21, 2014, 3:47 p.m.) Review request for KDE Frameworks and David Faure. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- Review request for KDE Frameworks. Repository: kinit Description --- Replace GPL proctitle code with BSD-licensed code from OpenSSH This also alters the calling sites so that we don't get kdeinit5 appearing multiple times in the process title. Diffs - src/kdeinit/proctitle.cpp a710e87dc12a40e9e679d2004980a86e77f39437 src/kdeinit/proctitle.h d0cadb289f93f15f2d9a885dc05911a49ab09877 src/config-kdeinit.h.cmake 2dd906019e44b0ba585817c87809d3ccff8bdce8 src/kdeinit/kinit.cpp 82d570c4453cf083e525125edd448b97d8d11bd3 ConfigureChecks.cmake c53e1defccaf0bcab33afde4342f2f9defb91335 Diff: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
