Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/ --- (Updated April 10, 2014, 1:14 p.m.) Status -- This change has been

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/#review55374 --- This review has been submitted with commit

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-08 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/ --- (Updated April 8, 2014, 10:30 a.m.) Review request for KDE Frameworks.

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-08 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/#review55243 --- Ship it! Ship It! - Michael Pyne On April 8, 2014, 8:30

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-07 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/#review55166 --- Any news? - Kevin Ottens On March 18, 2014, 8:14 p.m.,

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-07 Thread Alexander Richardson
On April 7, 2014, 5:24 p.m., Kevin Ottens wrote: Any news? Still wondering whether I should always use getgrouplist since AFAIK no platform without it is supported (yet) or should keep the fallback code. - Alexander --- This is an

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-04-07 Thread Michael Pyne
On April 7, 2014, 3:24 p.m., Kevin Ottens wrote: Any news? Alexander Richardson wrote: Still wondering whether I should always use getgrouplist since AFAIK no platform without it is supported (yet) or should keep the fallback code. Flip a coin if you have too. :) As long as the

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-03-19 Thread Alexander Richardson
On March 19, 2014, 4:11 a.m., Michael Pyne wrote: I think I'd argue against bothering with getgrouplist at all if we have to maintain a backup to it either way, it just makes the code messier. But I'll leave that part up to you (maybe it's that much faster). Still a couple of other

Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-03-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/ --- (Updated March 18, 2014, 9:14 p.m.) Review request for KDE Frameworks.

Re: Review Request 116881: Fix KUser::groups() and KUser::groupNames() on UNIX

2014-03-18 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116881/#review53383 --- I think I'd argue against bothering with getgrouplist at all