Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-21 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53705 --- Ship it! Looks reasonable to me, thanks! - Frank

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53725 --- This review has been submitted with commit

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-19 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53410 --- src/kcompletion_p.h

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-19 Thread David Gil Oliva
On March 19, 2014, 11:55 a.m., Frank Reininghaus wrote: src/kcompletion_p.h, line 338 https://git.reviewboard.kde.org/r/116886/diff/2/?file=255262#file255262line338 This is not strictly related to your changes, but it looks a bit unusual to have one plain bool and two bool

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-19 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/ --- (Updated March 19, 2014, 10:52 p.m.) Review request for KDE Frameworks.

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-19 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/ --- (Updated March 19, 2014, 11:01 p.m.) Review request for KDE Frameworks.

Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/ --- (Updated March 18, 2014, 11:01 p.m.) Review request for KDE Frameworks.

Re: Review Request 116886: Refactor private variables of KCompletion

2014-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53379 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 18, 2014,