Re: Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53955 --- This review has been submitted with commit b0f041b78f559a6682365c8f7e046fdec2582522 by Alex Merry to branch master. - Commit Hook On March 21, 2014, 5:15 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 21, 2014, 5:15 p.m.) Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 24, 2014, 11:44 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53953 --- This review has been submitted with commit 817f47214f94e2d76631cd5e8e87815a8945ebec by Alex Merry to branch master. - Commit Hook On March 21, 2014, 5:15 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 21, 2014, 5:15 p.m.) Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53954 --- This review has been submitted with commit 82b15ec1d65ff7e771567d19018d5102a43bdc2e by Alex Merry to branch master. - Commit Hook On March 21, 2014, 5:15 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 21, 2014, 5:15 p.m.) Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53956 --- This review has been submitted with commit 2bfb285f562115e1b85c8a911322e40da83130ef by Alex Merry to branch master. - Commit Hook On March 21, 2014, 5:15 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 21, 2014, 5:15 p.m.) Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116959: Remove KDE 4 references from kcmutils
On March 23, 2014, 9:35 p.m., David Faure wrote: src/kcmultidialog.cpp, line 424 https://git.reviewboard.kde.org/r/116959/diff/1/?file=256012#file256012line424 this if() isn't needed, already tested in the parent scope. Oops, worse than that. I'd replaced rootOnlyMessage() (QString) with useRootOnlyMessage() (bool). Fixed now. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53855 --- On March 24, 2014, 11:44 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 24, 2014, 11:44 a.m.) Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53855 --- Ship it! with one fix first src/kcmultidialog.cpp https://git.reviewboard.kde.org/r/116959/#comment37758 this if() isn't needed, already tested in the parent scope. - David Faure On March 21, 2014, 5:15 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- (Updated March 21, 2014, 5:15 p.m.) Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116959: Remove KDE 4 references from kcmutils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/ --- Review request for KDE Frameworks. Repository: kcmutils Description --- KCModuleProxy: remove deprecated forwarding methods These have been deprecated since at least kdelibs 4.0, and LXR says the only user is KCMultiDialog (since I fixed the call in systemsettings). KCModuleContainer: tidy up overridden methods Use the @reimp macro in the docs and use Q_DECL_OVERRIDE. KCModuleContainer: move modulelist variables to private object According to LXR, these were not used by anything. Remove TODO file This is full of API changes for KDE 4. Some were done, and others not (but would probably be considered too disruptive for KF5). Diffs - TODO 82f28e12903e51279ba12871c7b184a97c79a12a src/kcmodulecontainer.h 68aaeb008195aae154b1fbaf44c6f620753884b0 src/kcmodulecontainer.cpp 5b698ab2e320654a9ff3396c22b8aa239d4395d7 src/kcmoduleproxy.h d80d519dbf6e4015864d61daf65f67b99c136f26 src/kcmoduleproxy.cpp c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
