Re: Review Request 117011: Use bin/../share on Windows as a workaround
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated April 24, 2014, 9:57 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review55168 --- Any news? - Kevin Ottens On March 23, 2014, 11:28 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated March 23, 2014, 11:28 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review54439 --- I'm all for extending QStandardPaths, but obviously %KDEROOT% won't do. Is there any more standard way of doing this on Windows? Even if it's just relative to the executable - we could let QStandardPaths take care of that. - David Faure On March 23, 2014, 11:28 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated March 23, 2014, 11:28 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117011: Use bin/../share on Windows as a workaround
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
On March 24, 2014, 12:51 a.m., Aleix Pol Gonzalez wrote: So what should happen so that we didn't need the workaround? QStandardPaths would have to look in %KDEROOT%\share and not just C:\ProgramData. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53878 --- On March 24, 2014, 12:28 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated March 24, 2014, 12:28 a.m.) Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53880 --- Please add kdewin too. Given the outcome of the other RR, I'm not sure this is the correct solution, but I would prefer if someone with more knowledge of QStandardPaths and Windows could speak up. - Luigi Toscano On March 24, 2014, 12:28 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated March 24, 2014, 12:28 a.m.) Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117011: Use bin/../share on Windows as a workaround
On March 23, 2014, 11:51 p.m., Aleix Pol Gonzalez wrote: So what should happen so that we didn't need the workaround? Alexander Richardson wrote: QStandardPaths would have to look in %KDEROOT%\share and not just C:\ProgramData. So why aren't we adding this in Qt? Or even, why are we installing documentation in share/ if it doesn't make sense on Windows? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53878 --- On March 23, 2014, 11:28 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated March 23, 2014, 11:28 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdoctools Description --- This is a workaround for kdoctools for the same problem discussed in review #115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share. Diffs - src/xslt.cpp db67599 Diff: https://git.reviewboard.kde.org/r/117011/diff/ Testing --- Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this patch (KJsEmbed still has an unrelated problem on install step). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
