Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-05-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review58187 --- Ship it! Ship It! - David Faure On May 19, 2014, 10:26

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-05-20 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/ --- (Updated May 20, 2014, 11:12 a.m.) Status -- This change has been

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-05-19 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/ --- (Updated May 20, 2014, 12:26 a.m.) Review request for KDE Frameworks.

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-05-12 Thread Kevin Ottens
On April 12, 2014, 10:48 a.m., Alex Merry wrote: This is my preferred solution, and is hopefully only a temporary one. However, I know David Faure doesn't like it, and (I assume) would rather have a generic LIBEXEC variable. My view is that libexec should be used for stuff that's

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-30 Thread Alex Merry
On April 12, 2014, 10:48 a.m., Alex Merry wrote: This is my preferred solution, and is hopefully only a temporary one. However, I know David Faure doesn't like it, and (I assume) would rather have a generic LIBEXEC variable. My view is that libexec should be used for stuff that's

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review55497 --- This is my preferred solution, and is hopefully only a

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review55498 --- src/kcrash.cpp

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-09 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/ --- (Updated April 9, 2014, 10:47 a.m.) Review request for KDE Frameworks.

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-04-08 Thread Aleix Pol Gonzalez
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review54443 --- How does findExecutable() help at all? You plan on adding

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Aleix Pol Gonzalez
On March 28, 2014, 2:13 p.m., David Faure wrote: How does findExecutable() help at all? You plan on adding libexec to your $PATH? KStandardDirs::findExe used to look into libexec, IIRC. Maybe we could make it work. Or do something completely different. - Aleix

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Alex Merry
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread David Faure
On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: What about QStandardPaths::findExecutable? Actually this one should look into libexec too (at least the equivalent KStandardDirs::findExe used to). Alex Merry wrote: I'm pretty sure QStandardPaths won't look at libexec. How

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Aleix Pol Gonzalez
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Aleix Pol Gonzalez
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Kevin Ottens
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Aleix Pol Gonzalez
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-27 Thread Alex Merry
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/ --- Review request for KDE Frameworks. Repository: kcrash Description

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review53939 --- What about QStandardPaths::findExecutable? Actually this one

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/ --- (Updated March 24, 2014, 1:01 p.m.) Review request for KDE Frameworks.

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review53985 --- The correct solution is to get drkonqi merged into kcrash

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Alex Merry
On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: What about QStandardPaths::findExecutable? Actually this one should look into libexec too (at least the equivalent KStandardDirs::findExe used to). I'm pretty sure QStandardPaths won't look at libexec. How should it know where

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Hrvoje Senjan
On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: What about QStandardPaths::findExecutable? Actually this one should look into libexec too (at least the equivalent KStandardDirs::findExe used to). Alex Merry wrote: I'm pretty sure QStandardPaths won't look at libexec. How

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Aleix Pol Gonzalez
On March 24, 2014, 3:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Agreed. If somebody has the time, it would be interesting to figure out what can be uncommented (see commit

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Dan Vrátil
On March 24, 2014, 4:41 p.m., Alex Merry wrote: The correct solution is to get drkonqi merged into kcrash (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). Aleix Pol Gonzalez wrote: Agreed. If somebody has the time, it would be interesting to figure out

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Dan Vrátil
On March 24, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote: What about QStandardPaths::findExecutable? Actually this one should look into libexec too (at least the equivalent KStandardDirs::findExe used to). Alex Merry wrote: I'm pretty sure QStandardPaths won't look at libexec. How

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-24 Thread Alex Merry
On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: What about QStandardPaths::findExecutable? Actually this one should look into libexec too (at least the equivalent KStandardDirs::findExe used to). Alex Merry wrote: I'm pretty sure QStandardPaths won't look at libexec. How