Re: Review Request 117072: Add autotests for KPluginLoader and KPluginFactory

2014-03-27 Thread Kevin Ottens

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117072/#review54317
---

Ship it!


Ship It!

- Kevin Ottens


On March 26, 2014, 2:22 a.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117072/
 ---
 
 (Updated March 26, 2014, 2:22 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kservice
 
 
 Description
 ---
 
 Add autotests for KPluginLoader and KPluginFactory
 
 
 Diffs
 -
 
   autotests/CMakeLists.txt 220aa14bb1a38e0d5d822c93b9a110040488601d 
   autotests/kpluginfactorytest.cpp PRE-CREATION 
   autotests/kpluginloadertest.cpp PRE-CREATION 
   autotests/multiplugin.h PRE-CREATION 
   autotests/multiplugin.cpp PRE-CREATION 
   autotests/nsaplugin.cpp 3c8fb47ad001c6760726564ba1815e3eeecb1502 
   autotests/unversionedplugin.h PRE-CREATION 
   autotests/unversionedplugin.cpp PRE-CREATION 
   autotests/versionedplugin.h PRE-CREATION 
   autotests/versionedplugin.cpp PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/117072/diff/
 
 
 Testing
 ---
 
 Builds, tests pass.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 117072: Add autotests for KPluginLoader and KPluginFactory

2014-03-27 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117072/
---

(Updated March 27, 2014, 4:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kservice


Description
---

Add autotests for KPluginLoader and KPluginFactory


Diffs
-

  autotests/CMakeLists.txt 220aa14bb1a38e0d5d822c93b9a110040488601d 
  autotests/kpluginfactorytest.cpp PRE-CREATION 
  autotests/kpluginloadertest.cpp PRE-CREATION 
  autotests/multiplugin.h PRE-CREATION 
  autotests/multiplugin.cpp PRE-CREATION 
  autotests/nsaplugin.cpp 3c8fb47ad001c6760726564ba1815e3eeecb1502 
  autotests/unversionedplugin.h PRE-CREATION 
  autotests/unversionedplugin.cpp PRE-CREATION 
  autotests/versionedplugin.h PRE-CREATION 
  autotests/versionedplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117072/diff/


Testing
---

Builds, tests pass.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 117072: Add autotests for KPluginLoader and KPluginFactory

2014-03-25 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117072/#review54150
---

Ship it!


Yay unit tests!!

- Aleix Pol Gonzalez


On March 26, 2014, 2:22 a.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117072/
 ---
 
 (Updated March 26, 2014, 2:22 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kservice
 
 
 Description
 ---
 
 Add autotests for KPluginLoader and KPluginFactory
 
 
 Diffs
 -
 
   autotests/CMakeLists.txt 220aa14bb1a38e0d5d822c93b9a110040488601d 
   autotests/kpluginfactorytest.cpp PRE-CREATION 
   autotests/kpluginloadertest.cpp PRE-CREATION 
   autotests/multiplugin.h PRE-CREATION 
   autotests/multiplugin.cpp PRE-CREATION 
   autotests/nsaplugin.cpp 3c8fb47ad001c6760726564ba1815e3eeecb1502 
   autotests/unversionedplugin.h PRE-CREATION 
   autotests/unversionedplugin.cpp PRE-CREATION 
   autotests/versionedplugin.h PRE-CREATION 
   autotests/versionedplugin.cpp PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/117072/diff/
 
 
 Testing
 ---
 
 Builds, tests pass.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel