Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 28, 2014, 9:37 a.m.) Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs (updated) - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54422 --- Ship it! Ship It! - Kevin Ottens On March 28, 2014, 9:37 a.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 28, 2014, 9:37 a.m.) Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 28, 2014, 11:05 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54284 --- Ship it! Less code! - Aleix Pol Gonzalez On March 27, 2014, 10:08 a.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 27, 2014, 10:08 a.m.) Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54288 --- Could the stubs be made inline? - Christoph Feck On March 27, 2014, 10:08 a.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 27, 2014, 10:08 a.m.) Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54289 --- To answer my own question: probably not, because the functions are used to access a property. src/widgets/ktextedit.cpp https://git.reviewboard.kde.org/r/117108/#comment37983 This variable can be removed. - Christoph Feck On March 27, 2014, 10:08 a.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 27, 2014, 10:08 a.m.) Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 27, 2014, 1:02 p.m.) Review request for KDE Frameworks. Changes --- Remove italic variable Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs (updated) - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54336 --- src/widgets/ktextedit.cpp https://git.reviewboard.kde.org/r/117108/#comment37995 Please inline it in the header instead. It's trivial enough to be dealt with that way. src/widgets/ktextedit.cpp https://git.reviewboard.kde.org/r/117108/#comment37996 ditto - Kevin Ottens On March 27, 2014, 1:02 p.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 27, 2014, 1:02 p.m.) Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117108: Deprecate KTextEdit clickmessage and use QTextEdit placeholder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/#review54344 --- src/widgets/ktextedit.cpp https://git.reviewboard.kde.org/r/117108/#comment37999 This variable can be removed. - Christoph Feck On March 27, 2014, 1:02 p.m., Benjamin Port wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117108/ --- (Updated March 27, 2014, 1:02 p.m.) Review request for KDE Frameworks. Repository: ktextwidgets Description --- Deprecate clickmessage and use QTextEdit placeholder. We lose ability to put text in italic. Diffs - src/widgets/ktextedit.h 36786bb src/widgets/ktextedit.cpp 9bc8b58 Diff: https://git.reviewboard.kde.org/r/117108/diff/ Testing --- Thanks, Benjamin Port ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
