Re: Review Request 117146: Remove unused dependencies

2014-03-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- (Updated March 30, 2014, 2:03 p.m.) Status -- This change has been

Re: Review Request 117146: Remove unused dependencies

2014-03-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/#review54602 --- This review has been submitted with commit

Re: Review Request 117146: Remove unused dependencies

2014-03-29 Thread Michael Palimaka
On March 29, 2014, 12:02 a.m., Aleix Pol Gonzalez wrote: src/kdeui/kglobalsettings.cpp, line 61 https://git.reviewboard.kde.org/r/117146/diff/1/?file=258003#file258003line61 Why comment it? We either need it or don't need it... I did this so that it's there but not there, like the

Review Request 117146: Remove unused dependencies

2014-03-28 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 117146: Remove unused dependencies

2014-03-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/#review54518 --- Ship it! Besides the small detail, looks good to me.