---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/
---
Review request for KDE Frameworks and kwin.
Repository: kwindowsystem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/#review57404
---
Looks good to me and I want to see it merged, but also an ACK
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/#review57407
---
Ship it!
AFAICT it is BIC but no SIC, no brainer.
- Kevin
On May 6, 2014, 3:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen argument.
- Martin
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 3:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/#review57444
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/
---
(Updated May 6, 2014, 8:08 p.m.)
Status
--
This change has been
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
AFAICT it is BIC but no SIC, no brainer.
Martin Gräßlin wrote:
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen
17 matches
Mail list logo
