Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Bhushan Shah
> On May 30, 2014, 4:10 p.m., Christoph Feck wrote: > > Good catch, merci! Any chance this fixes bug 330845? > > Martin Klapetek wrote: > Yup, it does. I had Eike especially test this for his comment #2 on that > bug, he says this fixes the problem :) > > Bhushan Shah wrote: > This fix

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Bhushan Shah
> On May 30, 2014, 4:10 p.m., Christoph Feck wrote: > > Good catch, merci! Any chance this fixes bug 330845? > > Martin Klapetek wrote: > Yup, it does. I had Eike especially test this for his comment #2 on that > bug, he says this fixes the problem :) This fixes bug indeed but scales up ic

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/ --- (Updated May 30, 2014, 10:55 a.m.) Status -- This change has been ma

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/#review58788 --- This review has been submitted with commit aa0035d0a69e84c053

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Martin Klapetek
> On May 30, 2014, 12:45 p.m., Aleix Pol Gonzalez wrote: > > src/kicontheme.cpp, line 480 > > > > > > The iconPath call doesn't look trivial. I don't think we want the call > > twice, put it in a variable maybe?

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Martin Klapetek
> On May 30, 2014, 12:40 p.m., Christoph Feck wrote: > > Good catch, merci! Any chance this fixes bug 330845? Yup, it does. I had Eike especially test this for his comment #2 on that bug, he says this fixes the problem :) - Martin ---

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/#review58782 --- src/kicontheme.cpp

Re: Review Request 118415: Fix looking up icons

2014-05-30 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/#review58781 --- Ship it! Good catch, merci! Any chance this fixes bug 330845?

Review Request 118415: Fix looking up icons

2014-05-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118415/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth