Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59377 --- Ship it! I guess you used QFile::link wrongly in your

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59456 --- This review has been submitted with commit

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-06 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- (Updated June 6, 2014, 3:33 p.m.) Status -- This change has been

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59457 --- This review has been submitted with commit

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-06 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- (Updated June 6, 2014, 3:33 p.m.) Status -- This change has been

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59123 --- Very good to see that it brings the FAM backend to be more in

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-04 Thread Matthew Dawson
On June 4, 2014, 3:38 a.m., David Faure wrote: autotests/kdirwatch_unittest.cpp, line 523 https://git.reviewboard.kde.org/r/118458/diff/1/?file=277318#file277318line523 The commit log doesn't mention any changes related to QFileSystemWatcher, only to the FAM backend. Are you sure

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-04 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- (Updated June 4, 2014, 1:05 p.m.) Review request for KDE Frameworks.

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-02 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59018 --- The high-level logic makes sense, but I would prefer for

Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-01 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- Review request for KDE Frameworks. Bugs: 329802