Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/#review59426 --- This review has been submitted with commit f23fb35f2daed46710

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/ --- (Updated June 6, 2014, 12:31 p.m.) Status -- This change has been ma

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-06 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/#review59425 --- Ship it! Only for the documentation. We abbreviate in code al

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/ --- (Updated June 6, 2014, 2:02 p.m.) Review request for KDE Frameworks and C

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-06 Thread Martin Klapetek
> On June 5, 2014, 10:22 p.m., Christoph Feck wrote: > > src/kiconloader.h, line 209 > > > > > > Are we still allowed to break binary compatibility? If not, please > > create a separate call. > > Martin Klapete

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-06 Thread Martin Klapetek
> On June 5, 2014, 10:22 p.m., Christoph Feck wrote: > > Thanks Martin for looking at the issue. > > > > Just one question: Is plasmashell the only application which needs to > > include the additional search path, or does every application wanting a > > tray icon call the addAppDir() function

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/#review59358 --- Thanks Martin for looking at the issue. Just one question: Is

Review Request 118561: Allow passing custom theme base path together with custom app themes

2014-06-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth