Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60749 --- This review has been submitted with commit

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- (Updated June 23, 2014, 6:30 a.m.) Status -- This change has been

Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- Review request for KDE Frameworks, David Faure and Harald Sitter. Bugs:

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-20 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60591 --- Ship it! looks good to me - Harald Sitter On June 20,

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60615 --- Strange, why wasn't this necessary in kdelibs4? - David

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-20 Thread Martin Gräßlin
On June 20, 2014, 7:05 p.m., David Faure wrote: Strange, why wasn't this necessary in kdelibs4? see the linked bug report. It's basically a regression due to introducing platform detection (X11 vs. Wayland) in both klauncher and KWindowSystem. My first idea to fix it was to check for

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

2014-06-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60630 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 20, 2014,