---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Aug. 24, 2014, 12:13 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Aug. 24, 2014, 12:13 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Aug. 24, 2014, 12:13 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/#review63182
---
Ship it!
Ship It!
- David Faure
On juil. 22, 2014, 11:17
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/#review62844
---
src/lib/plugin/kpluginloader.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Juli 22, 2014, 1:17 nachm.)
Review request for KDE Frameworks.
On Juli 22, 2014, 9:24 vorm., David Faure wrote:
src/lib/plugin/kpluginloader.h, line 316
https://git.reviewboard.kde.org/r/119079/diff/9/?file=291388#file291388line316
is there a unittest for that? (directory being a relative path)
Yes there is for KPluginLoader::findPlugins(),
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/#review62731
---
src/lib/plugin/kpluginloader.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Juli 20, 2014, 11:45 nachm.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/#review62680
---
src/lib/plugin/kpluginloader.h
On Juli 19, 2014, 11:27 vorm., Alexander Richardson wrote:
I see you haven't changed the KPluginLoader methods - have you looked to
see if they are the ones that are likely to be useful?
I looked at KDevelop and Kate, and it seems there the version return a list of
KPluginMetaData objects
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Juli 19, 2014, 3:15 nachm.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/#review62699
---
Ship it!
One more thing then I, at least, am happy for it to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Juli 19, 2014, 5:41 nachm.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Juli 18, 2014, 3:34 nachm.)
Review request for KDE Frameworks.
On Juli 12, 2014, 6:50 nachm., Alex Merry wrote:
I'm generally in favour of this. Other than the issues noted below, I have
two concerns:
1. Have you looked at some users of plugins and determined that the
particular methods you've added to KPluginLoader are ones that will be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Juli 8, 2014, 1:51 nachm.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/#review61635
---
I like the idea of having a method to list or load the
On Juli 5, 2014, 11:33 vorm., David Faure wrote:
I like the idea of having a method to list or load the plugins from a given
subdir of the plugin path.
The method that returns a QListQObject * could/should actually go into Qt
at some point. The rest is tied to our specific metadata
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated Juli 5, 2014, 5:20 nachm.)
Review request for KDE Frameworks.
On July 5, 2014, 9:33 a.m., David Faure wrote:
src/lib/plugin/kpluginmetadata.h, lines 204-205
https://git.reviewboard.kde.org/r/119079/diff/3/?file=286685#file286685line204
Make member vars private.
It's not like deriving from a value class makes any sense anyway, and
On July 5, 2014, 9:33 a.m., David Faure wrote:
src/lib/plugin/kpluginmetadata.h, lines 204-205
https://git.reviewboard.kde.org/r/119079/diff/3/?file=286685#file286685line204
Make member vars private.
It's not like deriving from a value class makes any sense anyway, and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated July 2, 2014, 9:46 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119079/
---
(Updated July 2, 2014, 12:25 a.m.)
Review request for KDE Frameworks.
24 matches
Mail list logo
