Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-14 Thread Alexander Richardson
> On Juli 13, 2014, 1:17 nachm., Mark Gaiser wrote: > > src/core/udsentry.cpp, line 72 > > > > > > I'm not sure if this is the correct approach either. > > > > When i'm looking at file.cpp (in kio/src/ios

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-14 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated July 14, 2014, 5:33 p.m.) Status -- This change has been ma

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-14 Thread Mark Gaiser
> On jul 13, 2014, 11:17 a.m., Mark Gaiser wrote: > > src/core/udsentry.cpp, line 72 > > > > > > I'm not sure if this is the correct approach either. > > > > When i'm looking at file.cpp (in kio/src/iosla

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62298 --- Ship it! Ship It! - Mark Gaiser On jul 13, 2014, 8:35 a.m.

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-14 Thread David Faure
> On July 13, 2014, 11:17 a.m., Mark Gaiser wrote: > > src/core/udsentry.cpp, line 72 > > > > > > I'm not sure if this is the correct approach either. > > > > When i'm looking at file.cpp (in kio/src/iosl

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-14 Thread Cristian Oneț
> On July 13, 2014, 11:17 a.m., Mark Gaiser wrote: > > src/core/udsentry.cpp, line 72 > > > > > > I'm not sure if this is the correct approach either. > > > > When i'm looking at file.cpp (in kio/src/iosl

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-13 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62245 --- src/core/udsentry.cpp

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-13 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 13, 2014, 8:35 a.m.) Review request for KDE Frameworks.

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-13 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 13, 2014, 8:35 a.m.) Review request for KDE Frameworks and

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-12 Thread Cristian Oneț
> On Iulie 12, 2014, 7:58 p.m., Nicolás Alvarez wrote: > > Windows has no concept of an integer UID/GID, it uses much longer SIDs to > > identify users. These are not returned by stat (stat always returns zero in > > the st_uid member). > > > > I would just ifdef away the UDS_USER and UDS_GROU

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-12 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62224 --- Windows has no concept of an integer UID/GID, it uses much lon

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-12 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-12 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:01 p.m.) Review request for KDE Frameworks.

Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-12 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- Review request for KDE Frameworks. Repository: kio Description ---