Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
On July 22, 2014, 10:50 p.m., Eike Hein wrote: Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread David Edmundson
On July 22, 2014, 10:50 p.m., Eike Hein wrote: Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
On July 22, 2014, 10:50 p.m., Eike Hein wrote: Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread David Edmundson
On July 22, 2014, 10:50 p.m., Eike Hein wrote: Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
On July 22, 2014, 10:50 p.m., Eike Hein wrote: Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
On July 22, 2014, 10:50 p.m., Eike Hein wrote: Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread David Edmundson
On July 22, 2014, 10:50 p.m., Eike Hein wrote: Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
On July 22, 2014, 10:50 p.m., Eike Hein wrote: Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/ --- (Updated July 23, 2014, 1:53 p.m.) Status -- This change has been

Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/#review62888 --- +1, this escentially means that it now will use the same code

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/#review62911 --- Two issues: - Existing Dialog instances don't get the corner