Re: Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Jan. 29, 2015, 3:16 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ Marco Martin wrote: to me either way it gets fixed i'm ok. the other option is to keep it called kdesu, so it wouldn't be coinstallable so distributions would need to make kdesu a package of its own, alternative with the kde4 kdesu, but it may look even more problematic to me David Faure wrote: Scripts will just have to be updated, just like scripts calling kioclient4, kde4-config, kstart, kdecp, kbuildsycoca4 and so many other things. We can't have both source-compat-for-scripts and co-installability. It's one or the other. Any updates on that? is this the right approach or should i try something else? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65734 --- On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: in kde4 kdesu was installed under bin it was actually also in libexec. just that KStandardDirs::findExe() looked in libexec paths, QStandardPaths doesn't... right, it seems on both places here, but is probably a distro thing. Any idea of a way to find stuff under libexec on kf5? in other places the path is burned in in a define set by cmake, but that's probably not flexible enough - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65738 --- On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: in kde4 kdesu was installed under bin it was actually also in libexec. just that KStandardDirs::findExe() looked in libexec paths, QStandardPaths doesn't... Marco Martin wrote: right, it seems on both places here, but is probably a distro thing. Any idea of a way to find stuff under libexec on kf5? in other places the path is burned in in a define set by cmake, but that's probably not flexible enough Actually it appears to me that it wasn't in bin for kde4, some distros just worked around that because users where whining. That being said, I think at this point moving it bin would be counterproductive as users really should use pkexec as it is cross-desktop, cross-distro (mind kdesudo on kubuntu for example) and provides meaningful workspace integration through the relevant polkit-agent gui. In fact at the kubuntu/debian bof at akademy we were talking about proposing exactly that for all our usage of kdesu as to possibly retry the entire bugger in favor of pkexec with kf6. - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65738 --- On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: in kde4 kdesu was installed under bin it was actually also in libexec. just that KStandardDirs::findExe() looked in libexec paths, QStandardPaths doesn't... Marco Martin wrote: right, it seems on both places here, but is probably a distro thing. Any idea of a way to find stuff under libexec on kf5? in other places the path is burned in in a define set by cmake, but that's probably not flexible enough Harald Sitter wrote: Actually it appears to me that it wasn't in bin for kde4, some distros just worked around that because users where whining. That being said, I think at this point moving it bin would be counterproductive as users really should use pkexec as it is cross-desktop, cross-distro (mind kdesudo on kubuntu for example) and provides meaningful workspace integration through the relevant polkit-agent gui. In fact at the kubuntu/debian bof at akademy we were talking about proposing exactly that for all our usage of kdesu as to possibly retry the entire bugger in favor of pkexec with kf6. Sorry, I did not see this review request sooner. See my attempt at fixing this bug (from KIO) here: https://git.reviewboard.kde.org/r/120185/ - Maarten --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65738 --- On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ Marco Martin wrote: to me either way it gets fixed i'm ok. the other option is to keep it called kdesu, so it wouldn't be coinstallable so distributions would need to make kdesu a package of its own, alternative with the kde4 kdesu, but it may look even more problematic to me Scripts will just have to be updated, just like scripts calling kioclient4, kde4-config, kstart, kdecp, kbuildsycoca4 and so many other things. We can't have both source-compat-for-scripts and co-installability. It's one or the other. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65734 --- On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:26 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65732 --- doesn't actually affect the second bug, if one were to write a krunner replacement that doesn't depend/ispartof plasma workspace one would still run into the broken behavior so long as kde-cli-tools are not installed - Harald Sitter On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65734 --- kdesu/CMakeLists.txt https://git.reviewboard.kde.org/r/120040/#comment45938 The comment should probably also say kdesu5 I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ - Lukáš Tinkl On Zář. 2, 2014, 8:27 odp., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Zář. 2, 2014, 8:27 odp.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65738 --- in kde4 kdesu was installed under bin it was actually also in libexec. just that KStandardDirs::findExe() looked in libexec paths, QStandardPaths doesn't... - Hrvoje Senjan On Sept. 2, 2014, 8:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 8:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120040: Install kdesu under bin
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ to me either way it gets fixed i'm ok. the other option is to keep it called kdesu, so it wouldn't be coinstallable so distributions would need to make kdesu a package of its own, alternative with the kde4 kdesu, but it may look even more problematic to me - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65734 --- On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools Description --- this is a part of adressing the bug https://bugs.kde.org/show_bug.cgi?id=338755 https://bugs.kde.org/show_bug.cgi?id=338756 in kde4 kdesu was installed under bin, and should still, being something that should be invokable but renames it to kdesu5, for coinstallability reasons therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 instead of kdesu Diffs - kdesu/CMakeLists.txt 2a70831 Diff: https://git.reviewboard.kde.org/r/120040/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
