Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-12 Thread Aleix Pol Gonzalez
On Sept. 11, 2014, 10:19 p.m., Aleix Pol Gonzalez wrote: Why is the component responsible for defining how it's going to be visually integrated with the host application? Do we get to hit the scrollbar if the component doesn't have a margin and it's by the screen's border? Hugo

Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/ --- Review request for KDE Frameworks and Christoph Cullmann. Bugs: 158379

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/#review66286 --- Ship it! The patch looks good. Please commit. If we find

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/ --- (Updated Sept. 11, 2014, 9:24 p.m.) Review request for KDE Frameworks

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
On Sept. 11, 2014, 7:39 p.m., Dominik Haumann wrote: src/view/kateview.cpp, line 373 https://git.reviewboard.kde.org/r/120147/diff/1/?file=311597#file311597line373 this should be right spacer, right? :-) All fixed. Will push. Thanks for the review. Don't hesitate to ping me in case

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/#review66298 --- Why is the component responsible for defining how it's going

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
On Sept. 11, 2014, 10:19 p.m., Aleix Pol Gonzalez wrote: Why is the component responsible for defining how it's going to be visually integrated with the host application? Do we get to hit the scrollbar if the component doesn't have a margin and it's by the screen's border? Why is