Re: Review Request 120185: Look for kdesu in the correct location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Feb. 9, 2015, 5:41 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - autotests/krununittest.cpp b1da9aa src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review75682 --- Ship it! libexec/kf5 sounds sensible to me. I'd say, barring any objections, please push this as it solves a real problem. - Sebastian Kügler On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Oct. 4, 2014, 3:32 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - autotests/krununittest.cpp b1da9aa src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review74983 --- any updates on that? here the patch works correctly after i make kdesu to be installed under CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR I would push this asap, since kdesu in Plasma 5 is *still* broken. if CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 is ok (that seems where it's the safest from a coinstallability pov), i'll move where kdesu is installed as well - Marco Martin On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Oct. 4, 2014, 3:32 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - autotests/krununittest.cpp b1da9aa src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote: any updates on that? here the patch works correctly after i make kdesu to be installed under CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR I would push this asap, since kdesu in Plasma 5 is *still* broken. if CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 is ok (that seems where it's the safest from a coinstallability pov), i'll move where kdesu is installed as well as in, would still need http://paste.opensuse.org/67799408 - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review74983 --- On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Oct. 4, 2014, 3:32 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - autotests/krununittest.cpp b1da9aa src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote: any updates on that? here the patch works correctly after i make kdesu to be installed under CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR I would push this asap, since kdesu in Plasma 5 is *still* broken. if CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 is ok (that seems where it's the safest from a coinstallability pov), i'll move where kdesu is installed as well Marco Martin wrote: as in, would still need http://paste.opensuse.org/67799408 now kdesu is in CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review74983 --- On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Oct. 4, 2014, 3:32 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - autotests/krununittest.cpp b1da9aa src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review67887 --- libexec/kf5 is necessary for it to be co-installable with KDE SC 4, no? - David Faure On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Sept. 13, 2014, 3:59 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - src/core/config-kiocore.h.cmake 3c2e4a8 src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Oct. 4, 2014, 3:32 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Look for kdesu in libexec/kf5 If you want it to be renamed or installed some other place please comment here: https://git.reviewboard.kde.org/r/120040 I don't have a strong opion on this and will just adapt to whatever Marco decides. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs (updated) - autotests/krununittest.cpp b1da9aa src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing (updated) --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: this approach is probably better than https://git.reviewboard.kde.org/r/120040/ Maarten De Meyer wrote: I think we'll need both. We still need to rename the kdesu binary, no? Marco Martin wrote: if it goes in libexec yes, otherwise if it goes in libexec/kf5 shouldn't be necessary Can we get an update on how we should proceed? Do we rename the binary? move it to libexec/kf5? Is my patch correct, etc.. I'll also update the unit test once a decision is made. - Maarten --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review66656 --- On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Sept. 13, 2014, 3:59 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - src/core/config-kiocore.h.cmake 3c2e4a8 src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review66656 --- this approach is probably better than https://git.reviewboard.kde.org/r/120040/ - Marco Martin On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Sept. 13, 2014, 3:59 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - src/core/config-kiocore.h.cmake 3c2e4a8 src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: this approach is probably better than https://git.reviewboard.kde.org/r/120040/ I think we'll need both. We still need to rename the kdesu binary, no? - Maarten --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review66656 --- On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Sept. 13, 2014, 3:59 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - src/core/config-kiocore.h.cmake 3c2e4a8 src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120185: Look for kdesu in the correct location
On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: this approach is probably better than https://git.reviewboard.kde.org/r/120040/ Maarten De Meyer wrote: I think we'll need both. We still need to rename the kdesu binary, no? if it goes in libexec yes, otherwise if it goes in libexec/kf5 shouldn't be necessary - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review66656 --- On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Sept. 13, 2014, 3:59 p.m.) Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - src/core/config-kiocore.h.cmake 3c2e4a8 src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120185: Look for kdesu in the correct location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- Review request for KDE Frameworks and David Faure. Bugs: 338755 https://bugs.kde.org/show_bug.cgi?id=338755 Repository: kio Description --- kdesu is installed in libexec/ look for it there first. I left the findExecutable search as a backup. Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be installed in libexec/kf5? Insert 'kdesu' at the end to show a nicer error. If we leave this part out the error is Could not launch 'root' which is somewhat correct but not as easy to figure out as Could not launch 'kdesu' Also added an unrelated QFile::decodeName() call. Diffs - src/core/config-kiocore.h.cmake 3c2e4a8 src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
