---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/#review66567
---
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem different things to me.
I can rename it, but then it is inconsistent with most other FindXXX.cmake's,
as they skip the lib prefix.
- Christoph
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem different things to me.
Christoph Cullmann wrote:
I can rename it, but then it is inconsistent with most other
FindXXX.cmake's, as they skip the lib prefix.
I'm
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem different things to me.
Christoph Cullmann wrote:
I can rename it, but then it is inconsistent with most other
FindXXX.cmake's, as they skip the lib prefix.
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem different things to me.
Christoph Cullmann wrote:
I can rename it, but then it is inconsistent with most other
FindXXX.cmake's, as they skip the lib prefix.
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem different things to me.
Christoph Cullmann wrote:
I can rename it, but then it is inconsistent with most other
FindXXX.cmake's, as they skip the lib prefix.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/
---
(Updated Sept. 15, 2014, 6:30 p.m.)
Review request for KDE Frameworks
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote:
Shouldn't it be called FindLibGit2?
Git2 and LibGit2 seem different things to me.
Christoph Cullmann wrote:
I can rename it, but then it is inconsistent with most other
FindXXX.cmake's, as they skip the lib prefix.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/#review66593
---
Yep, I think the name change is sensible.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/
---
(Updated Sept. 15, 2014, 6:56 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/#review66594
---
Ship it!
Ship It!
- Alex Merry
On Sept. 15, 2014, 6:56
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/
---
(Updated Sept. 15, 2014, 7:11 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/
---
Review request for KDE Frameworks and Alex Merry.
Repository:
13 matches
Mail list logo