Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- (Updated Jan. 10, 2015, 5:12 p.m.) Status -- This change has been ma

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72750 --- Ship it! Looks goot to me. - Valentin Rusu On Dec. 29, 201

Re: Review Request 120388: Do not sync if wallet file does not exist

> On Sept. 27, 2014, 11:59 a.m., Arjun AK wrote: > > src/runtime/kwalletd/backend/kwalletbackend.cc, line 421 > > > > > > Is the return value correct? Perhaps better file a bug report? - Valentin ---

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- (Updated Dec. 29, 2014, 6:47 p.m.) Review request for KDE Frameworks, Àle

Re: Review Request 120388: Do not sync if wallet file does not exist

> On Dec. 29, 2014, 3:58 a.m., David Faure wrote: > > low-level review: no need to create a QFile, use QFile::exists(path) > > > > higher-level review: ensuring that a file exists before calling KSaveFile, > > which *creates* the file, sounds weird. I mean, isn't this exactly what > > will hap

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72634 --- low-level review: no need to create a QFile, use QFile::exists

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- (Updated Dec. 11, 2014, 2:16 a.m.) Review request for KDE Frameworks, Àle

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review71775 --- +1 Makes sense to me, still I'd like somebody more proficient

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review71740 --- Ping. - Arjun AK On Sept. 27, 2014, 5:29 p.m., Arjun AK wro

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review67522 --- src/runtime/kwalletd/backend/kwalletbackend.cc

Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- Review request for KDE Frameworks. Repository: kwallet Description