Re: Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Jan. 10, 2015, 4:09 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120878: Remove unused header
On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote: I should have asked, do you have commit access or do you need someone to merge this? I do have commit access, but I am okay if anyone commits it too. I just had little time to do so. - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review73573 --- On Out. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Out. 29, 2014, 2:27 a.m.) Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review73573 --- I should have asked, do you have commit access or do you need someone to merge this? - David Edmundson On Oct. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Oct. 29, 2014, 2:27 a.m.) Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review71093 --- Ship it! I just tested the Linux build still compiles fine. Ship it - David Edmundson On Oct. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Oct. 29, 2014, 2:27 a.m.) Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
