Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/ --- (Updated Dec. 6, 2014, 8:20 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kdewin. Repository: kbookmarks Description --- Konqueror references KBookmarkOwner::FutureBookmark, which is not properly exported, causing the build to fail. Diffs - src/kbookmarkowner.h 4d6fe0b Diff: https://git.reviewboard.kde.org/r/121075/diff/ Testing --- It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/#review71448 --- Ship it! Ship It! - David Faure On Nov. 8, 2014, 10:13 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/ --- (Updated Nov. 8, 2014, 10:13 p.m.) Review request for KDE Frameworks and kdewin. Repository: kbookmarks Description --- Konqueror references KBookmarkOwner::FutureBookmark, which is not properly exported, causing the build to fail. Diffs - src/kbookmarkowner.h 4d6fe0b Diff: https://git.reviewboard.kde.org/r/121075/diff/ Testing --- It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/#review71451 --- Ship it! Ship It! - Nicolás Alvarez On Nov. 8, 2014, 7:13 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/ --- (Updated Nov. 8, 2014, 7:13 p.m.) Review request for KDE Frameworks and kdewin. Repository: kbookmarks Description --- Konqueror references KBookmarkOwner::FutureBookmark, which is not properly exported, causing the build to fail. Diffs - src/kbookmarkowner.h 4d6fe0b Diff: https://git.reviewboard.kde.org/r/121075/diff/ Testing --- It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/ --- Review request for KDE Frameworks and kdewin. Repository: kbookmarks Description --- Konqueror references KBookmarkOwner::FutureBookmark, which is not properly exported, causing the build to fail. Diffs - src/kbookmarkowner.h 4d6fe0b Diff: https://git.reviewboard.kde.org/r/121075/diff/ Testing --- It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
