Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-19 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

(Updated Nov. 20, 2014, 3:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-12 Thread Pedro Francisco

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/#review70280
---

Ship it!


Ship It!

- Pedro Francisco


On Nov. 8, 2014, 10:14 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121076/
 ---
 
 (Updated Nov. 8, 2014, 10:14 p.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 kdepasswd, which requires it, is already disabled on Windows. There is also 
 konq-plugins/shellcmdplugins which was also disabled on Windows, but 
 konq-plugins is entirely disabled now.
 
 
 Diffs
 -
 
   CMakeLists.txt f02b069 
 
 Diff: https://git.reviewboard.kde.org/r/121076/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-09 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/#review70147
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 8, 2014, 10:14 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121076/
 ---
 
 (Updated Nov. 8, 2014, 10:14 p.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 kdepasswd, which requires it, is already disabled on Windows. There is also 
 konq-plugins/shellcmdplugins which was also disabled on Windows, but 
 konq-plugins is entirely disabled now.
 
 
 Diffs
 -
 
   CMakeLists.txt f02b069 
 
 Diff: https://git.reviewboard.kde.org/r/121076/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121076: Do not require KF5::Su on Windows

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

Review request for KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

(Updated Nov. 8, 2014, 10:14 p.m.)


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel