Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70680 --- dolphin/src/CMakeLists.txt

Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70681 --- Actually it's still broken: I didn't notice because I did not

Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
On Nov. 20, 2014, 9 a.m., Luca Beltrame wrote: Actually it's still broken: I didn't notice because I did not build tests: /srv/jenkins/workspace/kde-baseapps_frameworks_qt5/konqueror/src/konqapplication.h:28:46: error: expected initializer before ‘:’ token The line being

Re: Review Request 121078: Fix exports.

2014-11-19 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/ --- (Updated Nov. 20, 2014, 3:29 a.m.) Status -- This change has been

Re: Review Request 121078: Fix exports.

2014-11-19 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70678 --- This breaks compilation on Linux (was this tested?) and on

Re: Review Request 121078: Fix exports.

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70148 --- Ship it! Looks good to me, really useful and definitely a

Review Request 121078: Fix exports.

2014-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/ --- Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: